Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint #1379

Merged
merged 3 commits into from
Mar 24, 2025
Merged

Pylint #1379

merged 3 commits into from
Mar 24, 2025

Conversation

benma
Copy link
Collaborator

@benma benma commented Mar 11, 2025

No description provided.

@benma benma requested a review from NickeZ March 11, 2025 11:07
Copy link
Collaborator

@NickeZ NickeZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@benma
Copy link
Collaborator Author

benma commented Mar 12, 2025

Damn, the fixed-up lint script now correctly exits with non-zero exit code while before it failed to report the error:

py/bitbox02/setup.py:17:0: W0402: Uses of a deprecated module 'distutils.core' (deprecated-module)

Need to fix this too now I guess 😅

@benma benma force-pushed the pylint branch 2 times, most recently from 39d55ed to 868065b Compare March 23, 2025 18:59
benma added 3 commits March 23, 2025 20:00
```
setup.py:17:0: W0402: Uses of a deprecated module'distutils.core' (deprecated-module)
```
```
./scripts/lint-python: line 42: ((: 22 \& 1 : syntax error: invalid arithmetic operator (error token is "\& 1 ")
./scripts/lint-python: line 46: ((: 22 \& 2 : syntax error: invalid arithmetic operator (error token is "\& 2 ")
./scripts/lint-python: line 50: ((: 22 \& 4 : syntax error: invalid arithmetic operator (error token is "\& 4 ")
./scripts/lint-python: line 54: ((: 22 \& 8 : syntax error: invalid arithmetic operator (error token is "\& 8 ")
./scripts/lint-python: line 57: ((: 22 \& 16 : syntax error: invalid arithmetic operator (error token is "\& 16 ")
./scripts/lint-python: line 61: ((: 22 \& 32 : syntax error: invalid arithmetic operator (error token is "\& 32 ")
```
@benma benma merged commit d1d776e into BitBoxSwiss:master Mar 24, 2025
4 checks passed
@benma benma deleted the pylint branch March 24, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants